This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
New submission flow: Your consent screen (EXPOSUREAPP-3735) #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderAlferov
added
enhancement
AlexanderAlferov
requested review from
d4rken,
chiljamgossow,
harambasicluka and
a team
Oliver-Zimmerman
previously approved these changes
Dec 1, 2020
SamuraiKek
reviewed
Dec 2, 2020
Corona-Warn-App/src/main/res/layout/fragment_submission_your_consent.xml
Show resolved
Hide resolved
SamuraiKek
reviewed
Dec 2, 2020
Corona-Warn-App/src/main/res/layout/fragment_submission_your_consent.xml
Show resolved
Hide resolved
SamuraiKek
reviewed
Dec 2, 2020
Corona-Warn-App/src/main/res/layout/fragment_submission_your_consent.xml
Show resolved
Hide resolved
|
This looks good to me. There are some minor design differences to figma but they are includes that were already added in a different PR. I'm not sure if these should be changed here so once all your checks pass I'll approve it. |
Oliver-Zimmerman
previously approved these changes
Dec 2, 2020
SamuraiKek
previously approved these changes
Dec 2, 2020
…-your-consent-screen # Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/viewmodel/SubmissionFragmentModule.kt
AlexanderAlferov
dismissed stale reviews from SamuraiKek and Oliver-Zimmerman
via
4d3c5b4
Oliver-Zimmerman
approved these changes
Dec 2, 2020
SamuraiKek
approved these changes
Dec 2, 2020
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your consent screen.
Navigation would be placed in separate PR.