Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

New submission flow: Update test result pending screen (EXPOSUREAPP-3738) #1778

Merged
merged 12 commits into from
Dec 2, 2020
Merged

New submission flow: Update test result pending screen (EXPOSUREAPP-3738) #1778

merged 12 commits into from
Dec 2, 2020

Conversation

AlexanderAlferov
Copy link
Contributor

Updated test result pending steps and simple step entry custom view.

Test_result_pending_screenshot

@AlexanderAlferov AlexanderAlferov added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels Dec 1, 2020
@AlexanderAlferov AlexanderAlferov added this to the 1.9.0 milestone Dec 1, 2020
@AlexanderAlferov AlexanderAlferov requested a review from a team December 1, 2020 12:31
@AlexanderAlferov AlexanderAlferov changed the title Update test result pending screen (EXPOSUREAPP-3738) New submission flow: Update test result pending screen (EXPOSUREAPP-3738) Dec 1, 2020
@d4rken d4rken self-requested a review December 2, 2020 06:25
@d4rken d4rken self-assigned this Dec 2, 2020
d4rken
d4rken suggested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but...
The consent view padding does not match the mockups, needs less top margin and more bottom margin.

The line connecting the steps also seems to be thinner than on the mockups, but that's not new in this PR 🤔

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/view/SimpleStepEntry.kt Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/include_submission_test_result.xml Show resolved Hide resolved
@AlexanderAlferov
Copy link
Contributor Author

AlexanderAlferov commented Dec 2, 2020 •
edited

Looks good, but...
The consent view padding does not match the mockups, needs less top margin and more bottom margin.

The line connecting the steps also seems to be thinner than on the mockups, but that's not new in this PR 🤔

Yes, mockups are not 100% compliant right now with our guideline, so there could be slight differences.

@ralfgehrer ralfgehrer self-assigned this Dec 2, 2020
@ralfgehrer
Copy link
Contributor

Looks good, but...
The consent view padding does not match the mockups, needs less top margin and more bottom margin.
The line connecting the steps also seems to be thinner than on the mockups, but that's not new in this PR 🤔

Yes, mockups are not 100% compliant right now with our guideline, so there could be slight differences.

In the screenshot, however, the padding on top of the consent is larger than the one below.

@ralfgehrer ralfgehrer added the text change PRs with text changes. label Dec 2, 2020
@AlexanderAlferov
Copy link
Contributor Author

Looks good, but...
The consent view padding does not match the mockups, needs less top margin and more bottom margin.
The line connecting the steps also seems to be thinner than on the mockups, but that's not new in this PR 🤔

Yes, mockups are not 100% compliant right now with our guideline, so there could be slight differences.

In the screenshot, however, the padding on top of the consent is larger than the one below.

True, added padding as was discussed.
Vuzix View_20201202_140332_125

ralfgehrer
ralfgehrer reviewed Dec 2, 2020
View reviewed changes
Corona-Warn-App/src/main/res/layout/include_submission_test_result.xml
android:layout_width="@dimen/match_constraint"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/spacing_medium"
android:paddingBottom="@dimen/spacing_small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to be medium afterall.

janetback
janetback approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 0a5ff1b into release/1.9.x Dec 2, 2020
@ralfgehrer ralfgehrer deleted the feature/3738-update-test-result-screen branch December 2, 2020 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@d4rken d4rken d4rken approved these changes

@Oliver-Zimmerman Oliver-Zimmerman Oliver-Zimmerman approved these changes

@janetback janetback janetback approved these changes

@harambasicluka harambasicluka Awaiting requested review from harambasicluka

@SabineLoss SabineLoss Awaiting requested review from SabineLoss

Assignees

@ralfgehrer ralfgehrer

@d4rken d4rken

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlexanderAlferov @ralfgehrer @d4rken @Oliver-Zimmerman @janetback @harambasicluka