Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix countries missing in onboarding after in-app reset (EXPOSUREAPP-4203) #1849

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Fix countries missing in onboarding after in-app reset (EXPOSUREAPP-4203) #1849

merged 3 commits into from
Dec 10, 2020

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Dec 9, 2020

Remove the extra flow that would cache the countries. The app config itself is cached already.
When accessing the country list they will be mapped from the latest available app config.

Testing

  • Check the country list in on-boarding and interop settings
  • Reset the app via in-app data reset
  • Check the country list again

@d4rken
Remove the extra flow that would cache the countries. The app config …
654cd10 
…itself is cached already.

When accessing the countrylist they will be mapped from the latest available app config.
@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers labels Dec 9, 2020
@d4rken d4rken added this to the 1.8.0 milestone Dec 9, 2020
@d4rken d4rken requested a review from a team December 9, 2020 11:16
@ralfgehrer ralfgehrer self-assigned this Dec 9, 2020
ralfgehrer
ralfgehrer previously approved these changes Dec 9, 2020
View reviewed changes
chiljamgossow
chiljamgossow previously approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the reset, and there were flags shown in the onboarding.

@SamuraiKek
Copy link
Contributor

SamuraiKek commented Dec 9, 2020 •
edited

I've observed a strange behaviour while testing:

My app has been installed for about 2 weeks on my Huawei device which I've used to test this fix, and the first time I've tried to reset the app, the country list still didn't show up in the onboarding.
I went to interop settings and it showed up in there. After that I reset the app again and nothing happened for a good 5 seconds until I was brought to the onboarding screen.
The onboarding screen still didn't have the country list and after completing the onboarding I went to the interop settings where the list showed up.

After this I deleted my app data and tried it again.
This time country list also showed up in onboarding as well as the interop settings. But the behaviour of the app hanging after resetting the app a second time still happens.

Not sure what to make of this.

EDIT: After further testing, the app hanging doesn't happen on INT but it does happen on WRU_XD and XA, probably other environments also which I haven't tested yet.

@d4rken d4rken dismissed stale reviews from chiljamgossow and ralfgehrer via f86f53f December 9, 2020 17:51
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.4% 15.4% Coverage
0.0% 0.0% Duplication

@d4rken
Copy link
Member Author

d4rken commented Dec 9, 2020

After this I deleted my app data and tried it again.
This time country list also showed up in onboarding as well as the interop settings. But the behaviour of the app hanging after resetting the app a second time still happens.

I'm looking into it, thanks.

@ralfgehrer ralfgehrer added the prio PRs to review first. label Dec 10, 2020
@d4rken d4rken merged commit 2b84ce8 into release/1.8.x Dec 10, 2020
@d4rken d4rken deleted the fix/4203-countries-in-onboarding-missing branch December 10, 2020 10:20
@d4rken
Copy link
Member Author

d4rken commented Dec 10, 2020

I think what @SamuraiKek is experiencing is related to a blocking call on the mainthread for which I will open an extra PR.

@d4rken d4rken mentioned this pull request Dec 10, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuraiKek SamuraiKek SamuraiKek left review comments

@ralfgehrer ralfgehrer ralfgehrer left review comments

@chiljamgossow chiljamgossow chiljamgossow left review comments

Assignees

@ralfgehrer ralfgehrer

@SamuraiKek SamuraiKek

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d4rken @SamuraiKek @ralfgehrer @chiljamgossow