Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust "abort warn others" dialog (EXPOSUREAPP-4253) #1874

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Adjust "abort warn others" dialog (EXPOSUREAPP-4253) #1874

merged 6 commits into from
Dec 11, 2020

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Dec 11, 2020

We no longer leave the screen if we cancel the cancel dialog 馃槃.

  • Change dialog cancel behavior. Stay on screen.
  • Switch dialog button. The "positive" action is always in reference to the dialog's question. So positive here means to not warn others, while "warn others" is the negative action that cancels the dialog.
  • Also removed some unused codes and did a little code cleanup.

Testing

  • Basically what is described in Jira: Positive TAN, press cancel on the test result screen, cancel the dialog.

@d4rken
Change dialog cancel behavior. Stay on screen.
40606ac
@d4rken
Switch dialog button.
3b5b970 
The "positive" action is always in reference to the dialog's question.
So positive here means to not warn others, while "warn others" is the negative action that cancels the dialog.
@d4rken
Remove unused code.
b57b4aa
@d4rken
Simplify fragment init.
5e035c3
@d4rken
LINTs
1bdcd9a
@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Dec 11, 2020
@d4rken d4rken added this to the 1.9.0 milestone Dec 11, 2020
@d4rken d4rken requested a review from a team December 11, 2020 10:50
@ralfgehrer ralfgehrer self-assigned this Dec 11, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

ralfgehrer
ralfgehrer approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pixel (Android 10)

@Oliver-Zimmerman Oliver-Zimmerman self-assigned this Dec 11, 2020
Oliver-Zimmerman
Oliver-Zimmerman approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@Oliver-Zimmerman Oliver-Zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pixel 5, works as expected. Code looks good to me.

@ralfgehrer ralfgehrer merged commit a6286ff into release/1.9.x Dec 11, 2020
@ralfgehrer ralfgehrer deleted the fix/4253-abort-warn-others-dialog branch December 11, 2020 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@Oliver-Zimmerman Oliver-Zimmerman Oliver-Zimmerman approved these changes

Assignees

@ralfgehrer ralfgehrer

@Oliver-Zimmerman Oliver-Zimmerman

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d4rken @ralfgehrer @Oliver-Zimmerman