Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Home screen only shows FAQ when leaving Consent (EXPOSUREAPP-4275) #1875

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

Oliver-Zimmerman
Copy link
Contributor

@Oliver-Zimmerman Oliver-Zimmerman commented Dec 11, 2020

Description

Small condition change for the positive card to be shown. Short oversight on my part. Apologies.

Positive test result should be shown if test result has been seen. Adjusted the state function for this logic to be true.

Adjusted tests to match.

Steps to reproduce

1.Scan positive QR code
4.Tap on "Continue" on the "Test Result is Available" screen
5.Tap on "Don't share" on the OS consent screen
6.Tap on "X" on the "Positive Test Result (no consent)" screen
8.Tap on "Don't warn" in the confirmation pop-up
9. Positive Test Result card should now be shown

@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team December 11, 2020 10:52
@Oliver-Zimmerman Oliver-Zimmerman added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Dec 11, 2020
@Oliver-Zimmerman Oliver-Zimmerman added this to the 1.9.0 milestone Dec 11, 2020
@ralfgehrer ralfgehrer self-assigned this Dec 11, 2020
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pixel (Android 10).
Could also recover a previous install in the wrong state.

@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 76fad81 into release/1.9.x Dec 11, 2020
@ralfgehrer ralfgehrer deleted the fix/4274-wrong-homescreen-state branch December 11, 2020 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants