Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact Journal Polishing (EXPOSUREAPP-4466) #1983

Merged
merged 22 commits into from
Dec 23, 2020
Merged

Contact Journal Polishing (EXPOSUREAPP-4466) #1983

merged 22 commits into from
Dec 23, 2020

Conversation

axelherbstreith
Copy link
Contributor

@axelherbstreith axelherbstreith commented Dec 22, 2020 •
edited

  • Updated Layout of list items in overview screen
  • Added ripple effect to list items in overview screen
  • Fixed a small issue that shows the placeholder screen all the time when opening day and edit screen regardless whether the list is empty
  • Removed small corner radius in onboarding screen background
  • Removed scrollbar in overview screen
  • Aligned naming of xml files containing list items
  • Reformatted contact journal xml files

@axelherbstreith axelherbstreith added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Dec 22, 2020
@axelherbstreith axelherbstreith added this to the 1.11.0 milestone Dec 22, 2020
@axelherbstreith axelherbstreith self-assigned this Dec 22, 2020
@ralfgehrer
Copy link
Contributor

Please create tickets for PRs and reference them in the PR title & branch name. Otherwise, changes cannot be confirmed by testers.

@ralfgehrer ralfgehrer changed the title Contact Journal Polishing 5 Contact Journal Polishing (DEV) Dec 22, 2020
@BMItr BMItr self-assigned this Dec 23, 2020
@axelherbstreith axelherbstreith marked this pull request as ready for review December 23, 2020 11:54
@axelherbstreith axelherbstreith requested a review from a team December 23, 2020 11:54
BMItr
BMItr previously approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice polishing. Good that you removed unnecessary includes. ripple effect is also nice
Tested on Pixel 2 device.

@axelherbstreith axelherbstreith changed the title Contact Journal Polishing (DEV) Contact Journal Polishing (EXPOSUREAPP-4466) Dec 23, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli
Copy link
Contributor

mtwalli commented Dec 23, 2020

LGTM

SamuraiKek
SamuraiKek approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice polishes. I love that you removed the scrollbar from the days list. It looked kinda funky with it.

@mtwalli mtwalli self-requested a review December 23, 2020 14:37
@axelherbstreith axelherbstreith merged commit 82a1f74 into release/1.11.x Dec 23, 2020
@axelherbstreith axelherbstreith deleted the feature/4152-contact-diary-polishing-5 branch December 23, 2020 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuraiKek SamuraiKek SamuraiKek approved these changes

@BMItr BMItr BMItr approved these changes

@mtwalli mtwalli Awaiting requested review from mtwalli

Assignees

@BMItr BMItr

@axelherbstreith axelherbstreith

Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@axelherbstreith @ralfgehrer @mtwalli @SamuraiKek @BMItr