Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Rely on native observe from LiveData instead of observe2 (DEV) #1984

Merged
merged 7 commits into from
Dec 23, 2020
Merged

Rely on native observe from LiveData instead of observe2 (DEV) #1984

merged 7 commits into from
Dec 23, 2020

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Dec 22, 2020

Replace observe2 with LiveDate.observe.
Since kotlin 1.4 it not necessarily to write the old syntax of observing LiveData in the Fragments or Activities.

old syntax: viewModel.liveData.observe(this, Observer { // TODO})

new syntax: viewModel.liveData.observe(this) {// TODO}

Therefore we don't have to write our own extension function to achieve that or use extension function from lifecycle library that was doing the same.

For more information please have a look at the following resources:
1- https://developer.android.com/jetpack/androidx/releases/lifecycle#2.3.0-beta01
2- https://android-review.googlesource.com/c/platform/frameworks/support/+/1413815

  • UPDATE -
    I agreed with @d4rken to keep observe2 for Fragments as is

@mtwalli mtwalli requested a review from a team December 22, 2020 14:49
@d4rken
Copy link
Member

d4rken commented Dec 22, 2020

Thanks for your PR @mtwalli .

While I like that the syntax is now nicer by default, I don't like that we would have to specify viewLifecycleOwner everywhere, how can we make this nicer?

@d4rken d4rken self-assigned this Dec 22, 2020
@d4rken d4rken self-requested a review December 22, 2020 15:46
@mtwalli mtwalli changed the base branch from main to release/1.11.x December 23, 2020 07:46
@ralfgehrer ralfgehrer added the community Tag issues created by community members label Dec 23, 2020
@d4rken d4rken added this to the 1.11.0 milestone Dec 23, 2020
@d4rken d4rken added maintainers Tag pull requests created by maintainers and removed community Tag issues created by community members labels Dec 23, 2020
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4rken d4rken changed the title Rely on native observe from LiveDate instead of `oberve2 Rely on native observe from LiveData instead of observe2 (DEV) Dec 23, 2020
@d4rken d4rken merged commit 865b99e into corona-warn-app:release/1.11.x Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants