This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Rely on native observe
from LiveData instead of observe2
(DEV)
#1984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
observe2
withLiveDate.observe
.Since kotlin 1.4 it not necessarily to write the old syntax of observing
LiveData
in the Fragments or Activities.old syntax:
viewModel.liveData.observe(this, Observer { // TODO})
new syntax:
viewModel.liveData.observe(this) {// TODO}
Therefore we don't have to write our own extension function to achieve that or use extension function from lifecycle library that was doing the same.
For more information please have a look at the following resources:
1- https://developer.android.com/jetpack/androidx/releases/lifecycle#2.3.0-beta01
2- https://android-review.googlesource.com/c/platform/frameworks/support/+/1413815
I agreed with @d4rken to keep
observe2
for Fragments as is