This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Check device time (EXPOSUREAPP-2998) #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce time check behavior.
* Remove extra retrofit cache (use only LocalAppConfigSource.kt) * Exposure device time check * Reset user acknowledgement
Abort risk level calculation if time is incorrect.
…ct`, make it a body property and don't allow overriding via constructor.
d4rken
added
enhancement
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/DataReset.kt
…isk task abort conditions on incorrect device time.
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentViewModel.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/main/home/HomeFragmentViewModelTest.kt
mlenkeit
reviewed
Dec 23, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/internal/AppConfigSource.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Dec 23, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/mapping/CWAConfigMapper.kt
Show resolved
Hide resolved
ralfgehrer
reviewed
Dec 23, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/internal/ConfigDataContainer.kt
Show resolved
Hide resolved
ralfgehrer
reviewed
Dec 23, 2020
...viceForTesters/java/de/rki/coronawarnapp/test/appconfig/ui/AppConfigTestFragmentViewModel.kt
Show resolved
Hide resolved
ralfgehrer
reviewed
Dec 23, 2020
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/risk/RiskLevelTaskTest.kt
Show resolved
Hide resolved
mtwalli
reviewed
Dec 23, 2020
| android:theme="@style/switchBase" /> | ||
|
|
||
| </LinearLayout> | ||
|
|
There was a problem hiding this comment.
can you just use Switch without LinearLayout?
There was a problem hiding this comment.
We could, but I'm sure there will be more switches in the future to toggle other app config features, the whole box is there to contain those switches. We could maybe add a title to it, but IMHO it is okay as it is.
ralfgehrer
reviewed
Dec 23, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/devicetime/DeviceTimeHandler.kt
Show resolved
Hide resolved
mtwalli
reviewed
Dec 23, 2020
...arn-App/src/main/java/de/rki/coronawarnapp/appconfig/sources/remote/RemoteAppConfigSource.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Dec 23, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
previously approved these changes
Dec 23, 2020
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect device time handling.
Testing
AppConfigSourceoutput