This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Manual tan submission talkback error (EXPOSUREAPP-4099) #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuraiKek
added
maintainers
chiljamgossow
approved these changes
Dec 29, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a talkback issue where entering a full wrong TAN would make talkback skip one of the error messages.
This was happening because both textviews in the fragment were having the "accessibilityLiveRegion" property set to "assertive" and because the second textview only shows up when entering a full wrong TAN, it was hitching the focus from the other textview before that one got to be interpreted by talkback.
Also, I had to change the order in which the two error message textviews are displayed because the invisible one that shows up after entering the full wrong TAN will be last in the talkback stack when becoming visible. So even though in the UI, it comes in before the second textview, talkback was actually reading the second textview first and then the first one.
To test the fix, enable talkback in your settings and then enter a full wrong TAN inside the application.