This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Better handling of issues caused by time traveling (DownloadTask) (DEV) #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxExposureDetectionsPerDay is checked separately and will abort the download task if necessary.
…ck that causes it to not skip, if the last detection was in our future.
d4rken
changed the title
mtwalli
approved these changes
Jan 4, 2021
ralfgehrer
approved these changes
Jan 4, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely unrelated, but noticed while debugging #2001.
This adds additional checks to handle issues caused by time traveling gracefully.
We change the check "did we already perform an exposure detection in recent time" (24/checksPerDay), to be skipped if the timestamp of the last check is more than 2 hours in the future.