This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix missing timestamp on TracingFailed card (DEV) #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove risklevel requirement for showing the last submission timestamp on the TracingFailed card. This requirement does not exist on the TracingDisabled card either.
d4rken
added
bug
mtwalli
reviewed
Jan 7, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/tracing/states/TracingState.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
previously approved these changes
Jan 7, 2021
ralfgehrer
approved these changes
Jan 8, 2021
mtwalli
approved these changes
Jan 8, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed while working on something else.
The card looked like this:
I see no reason to not display the timestamp here. Seems to be an oversight from refactoring.
The TracingDisabled card also did not have this restriction to LOW/INCREASED risk levels.