This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix foreground state emissions (DEV) #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
chris-cwa
reviewed
Jan 15, 2021
| @Qualifier | ||
| @MustBeDocumented | ||
| @Retention(AnnotationRetention.RUNTIME) | ||
| annotation class ProcessLifecycle |
There was a problem hiding this comment.
ProcressLifecycleOwner.get(): LifecycleOwner, the interface is generic and there are multiple types of LifecycleOwner, so they don't get mixed up in the DI graph, we qualify this specific type of LifecycleOwner with the annotation, similar to how we handle Context.
There was a problem hiding this comment.
class Example constructor(@ProcessLifecycle val lifecycleOwner: LifecycleOwner)
chris-cwa
approved these changes
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the statistics I noticed that the foreground detection just wasn't working.
We did not emit the values and relied on setting the static property.