Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact Journal Location/Person not announced (EXPOSUREAPP-4459) #2147

Conversation

axelherbstreith
Copy link
Contributor

Changes were already merged in #2129 but due to a target base change to 1.11 this PR was reopened for 1.11.x

Fixes an issue where only the names of locations and persons in the contact journal overview screen were announced but not the types e.g. "John Doe" instead of "Person John Doe".

To test this changes, activate TalkBack, navigate to the contact journal overview screen and focus a person or location within a day element.

device-2021-01-18-143447

@axelherbstreith axelherbstreith added maintainers Tag pull requests created by maintainers accessibility Accessibility issues labels Jan 19, 2021
@axelherbstreith axelherbstreith added this to the 1.11.0 milestone Jan 19, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer self-assigned this Jan 19, 2021
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pixel (Android 10) - German Talkback

@ralfgehrer ralfgehrer merged commit 945d650 into release/1.11.x Jan 19, 2021
@ralfgehrer ralfgehrer deleted the feature/4459-contact-journal-person-location-not-announced-1.11 branch January 19, 2021 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Accessibility issues maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants