-
Notifications
You must be signed in to change notification settings - Fork 499
CircleCI config overhaul, instrumentation tests & screenshot automation (EXPOSUREAPP-4480,DEV) #2160
CircleCI config overhaul, instrumentation tests & screenshot automation (EXPOSUREAPP-4480,DEV) #2160
Conversation
Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/contactdiary/DiaryData.kt
Show resolved
Hide resolved
Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/util/security/DBPasswordTest.kt
Show resolved
Hide resolved
|
Could you also Zip the ScreenShots? So I could just donwload the zip. The idea is, to add this zip later also to the release notes. |
This would be merged after we have finished the statistics stuff so there is no delay due to pipeline issues. |
I think so. Will check. We could also link the artifacts on CircleCI directly, though the link will probably break after a few weeks? CircleCI artifact storage times out at some time.
What do you mean by that? |
There are also a lot of artifacts, which you maybe could zip? I could use these results for our internal reporting, but it would be easier to just download a zip. |
Screenshots, Instrumentation tests (release), unit tests (release) are now uploaded as .zip too. |
…strumentation-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Zip and upload test html reports instead of xml files.
…into feature/4480-circle-ci-overhaul-instrumentation-emulator-performance
Kudos, SonarCloud Quality Gate passed! |
@mtwalli, @AlexanderAlferov and me overhauled the CircleCI config, added instrumentation testing and automatic screenshots.
Highlights:
We tried Firebase Testlab, but it was not working out, due to lack of control over the whole process (more of a black box) and inability to use fastlane with it. There were also issues with our mocking library which could fail on newer API emulators if not run on
x86_64
architecture emulators, and firebase testlab doesn't allow us to enforce it.Because we previously didn't run instrumentation tests via CI, a few tests fell into disarray and will need fixing. The current config setup is already a huge improvement over the previous config and I think should merge it despite the failing instrumentation tests. Until we enforce the check to pass for branches, there should be no issue. A follow up PR can then be made stress free to fix the failing tests.
This was initially targeted for 1.12, but as this will require adjusting the branch restrictions, it would make sense to merge this into 1.11, we share the same branch restrictions between all branches. Then the only problematic branch would be 1.10.x which will soon be superseeded by 1.11.x.
Once the config is merged I will change the restrictions and all open PRs will have to pull the new config to run the correct tests.