This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Statistics (EXPOSUREAPP-3674) #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-3674) #2043 * Skeletons for showing statistics in the home screen feed. Introduce nested horizontally scrolling recycler view that supports dynamic content updates. * Fix homescreen unit test. * LINT doesn't like the TODO. * Refactor nested if to flatter when.
…to-1.12.x Merge 1.11.x into 1.12.x (DEV)
* Add placeholders for statistic UIs. * Satisfy the linter.
* Texts for statistics explanation screen * Added double quotes to statistics text
…new-infections-strings # Conflicts: # Corona-Warn-App/src/main/res/values-de/strings.xml # Corona-Warn-App/src/main/res/values/strings.xml
…-infections-strings Screen: Confirmed New Infections - string update (EXPOSUREAPP-4510)
* Texts for statistics explanation screen * Added double quotes to statistics text * Text change due to outdated moockups * FAQ link label added
* styles and strings * styles and strings * styles and strings
…atter-for-statistics-values Create NumberFormatter for Statistics Values (EXPOSUREAPP-4652)
* Texts for statistics explanation screen * Added double quotes to statistics text * Text change due to outdated moockups * FAQ link label added * Removed dot from 7-tage-mittlewert text
* Replace mock data with data loaded from server. * Revert unrelated change. * Some refactoring, add a generic statistics scope annotation. Clear retrofit cache on clear. * Clear statistic data on app reset. * Unit tests for StatisticsCache.kt * Implement tests for StatisticsModule init. * Add tests for statistics api. * Add statistics server tests that check signature validation behavior. * Add tests for StatisticsProvider behavior. * Tests for parsing statistics data. * LINTING * Add helper methods to access each cards values, and validate card KeyFigure count and types before exposing them. * LINTs. * Rename variable.
* Implement StatisticsNumberValueFormatter.kt and add tests * Fix ktlint issues * Improve StatisticsNumberValueFormatter.kt * Reduce parameters for formatter, adapt test * Define formatting function as top-level function instead of a function in object
* TrendArrowView * remove redundant frame layout * add content description
* Introduce getFormattedDate() * Update strings
* TrendArrowView * card 7-day-r-value implementation * margins and ripple * use decimals provided by backend
* update Infections Card layout * Revert some changes * Add primary label to statistics cards * Implement strings * Update Infections Card design * Update Infections Card design * Ignore MissingConstraints to satisfy lint * Add night drawable * Update dimensions * Update design * Remove icon duplicate * use StatisticsCardInfoButton style * Update layout
* Adjust layout to not cut off text on large text sizes. * Adjust layout to not cut off text on large text sizes.
# Conflicts: # Corona-Warn-App/src/main/res/values/strings.xml # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/main/home/HomeFragmentViewModelTest.kt
* Unify cards design * Change cards height * Layout update after merge * Revert layout changes
* Texts for statistics explanation screen * Initial commit with illustration and layout * First descriptions added * Legend added * Trends added * Navigation added * Night mode image added * Complete screen * Lint fix * Image update * Refactor
harambasicluka
previously approved these changes
Jan 20, 2021
|
Please do not merge until we have the final decision. |
…ormation screen (EXPOSUREAPP-4704) (#2175) * Override equals() of StatisticsHomeCard.Item to ignore onHelpAction click listener * Override hashCode() in StatisticsHomeCard.Item
* Unify cards design * Change cards height * Layout update after merge * Implement responsive layout manager * Update layout and refactor code * Satisfy lint * Update image padding * Code improvements
…2189) * Fix statistics data missing on in-app data reset due to no refresh being triggered. Don't do a full reset and add statistics data subscription timeout. * Fix test (bad changeset)
harambasicluka
previously approved these changes
Jan 22, 2021
ralfgehrer
approved these changes
Jan 22, 2021
harambasicluka
approved these changes
Jan 22, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't squash this.