This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix invisible tracing settings screen if the last calculation failed (EXPOSUREAPP-4717) #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TracingDetailsItemProvider is used for the tracing/risk details screen. This has specific behavior that the logging period is not shown if the last calculation failed. By reusing this data provider for the tracing settings, if the last calculation failed, we never set "loggingPeriod". If loggingPeriod is null, the databinding causes the layout to be invisible.
d4rken
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
ralfgehrer
approved these changes
Jan 22, 2021
LukasLechnerDev
approved these changes
Jan 22, 2021
LukasLechnerDev
deleted the
fix/tracing-details-empty-if-risk-calculation-failed
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TracingDetailsItemProvider is used for the tracing/risk details screen.
This has specific behavior that the logging period is not shown if the last calculation failed.
By reusing this data provider for the tracing settings, if the last calculation failed, we never set "loggingPeriod".
If loggingPeriod is null, the databinding causes the layout to be invisible.
Testing
Screenshot from 2021-01-21 18-46-40
Screenshot from 2021-01-21 18-46-30