This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Event survey skeletons (EXPOSUREAPP-4754) #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Nice Skeletons to implement the tech spec IMHO. |
…id protobuf class.
chris-cwa
previously approved these changes
Jan 28, 2021
| * Will throw an exception if no attestation could be obtained (e.g. no network) | ||
| */ | ||
| @Throws(SafetyNetException::class) | ||
| suspend fun attest(request: Request): Result |
There was a problem hiding this comment.
Marvellous interface method signature! Simple, clean, maintainable!
BMItr
previously approved these changes
Jan 28, 2021
|
Kudos, SonarCloud Quality Gate passed! |
BMItr
approved these changes
Jan 28, 2021
chris-cwa
approved these changes
Jan 28, 2021
mtwalli
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Skeleton classes for SafetyNet and EventSurveys. * Fix LINTs, test compile error. * Remove lint breaking TODOs. * Add SafetyNet requirement validation call to the attestation interface. * Don't return salt/nonce, just offer the caller directly the PPACAndroid protobuf class. * Add documentation, fix test build error. * Add documentation, fix test build error. * Add environment variables for data donation server and SafetyNet API key. * Remove unused function. * Fix EnvironmentSetupTest.kt
mtwalli
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Skeleton classes for SafetyNet and EventSurveys. * Fix LINTs, test compile error. * Remove lint breaking TODOs. * Add SafetyNet requirement validation call to the attestation interface. * Don't return salt/nonce, just offer the caller directly the PPACAndroid protobuf class. * Add documentation, fix test build error. * Add documentation, fix test build error. * Add environment variables for data donation server and SafetyNet API key. * Remove unused function. * Fix EnvironmentSetupTest.kt
SamuraiKek
pushed a commit
that referenced
this pull request
Feb 3, 2021
* Skeleton classes for SafetyNet and EventSurveys. * Fix LINTs, test compile error. * Remove lint breaking TODOs. * Add SafetyNet requirement validation call to the attestation interface. * Don't return salt/nonce, just offer the caller directly the PPACAndroid protobuf class. * Add documentation, fix test build error. * Add documentation, fix test build error. * Add environment variables for data donation server and SafetyNet API key. * Remove unused function. * Fix EnvironmentSetupTest.kt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skeleton classes for event based survey implementation to parallelize developer effort.