Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust Screenshots tests to reflect latest UI changes(EXPOSUREAPP-4878) #2247

Merged
merged 62 commits into from
Feb 3, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Feb 1, 2021

This PR is based on the changes made in #2235. Please check it first

  • Adjusted the following screenshots tests:
    1- Home screen tests
    2- Contact diary tests
    3- Statistics tests

  • Refactor Screenshot logic

  • Update versions in Gemfile.lock

Testing: Same as before for screenshots testing

1- Build APKs required for Screengrab
2- run fastlane screengrab

@jurajkusnier jurajkusnier self-assigned this Feb 2, 2021
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-review this once the TabBar PR is merged.

@d4rken d4rken self-assigned this Feb 2, 2021
@harambasicluka harambasicluka added the author merge PR to be merged by author label Feb 2, 2021
@harambasicluka
Copy link
Contributor

I added the label author merge due to this comment: #2247 (comment)
This PR has to be merged first: #2235

Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralfgehrer ralfgehrer self-assigned this Feb 3, 2021
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did NOT run all screenshots - please wait for Matthias' approval. He is currently executing the entire set.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtwalli mtwalli merged commit c7982aa into release/1.13.x Feb 3, 2021
@mtwalli mtwalli deleted the feature/4878-screenshots-tests branch February 3, 2021 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author merge PR to be merged by author maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants