Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Change escaping of percentage sign (DEV) #2263

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Change escaping of percentage sign (DEV) #2263

merged 3 commits into from
Feb 2, 2021

Conversation

ralfgehrer
Copy link
Contributor

All other options did not work well with the internal translation tool.

TEST:

  • Check the statistics info screen.
  • Scroll to Legend
  • See Trend
  • Check the description and make sure it says "...1%..." and "...5%..."

@ralfgehrer ralfgehrer added maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes. labels Feb 2, 2021
@ralfgehrer ralfgehrer added this to the 1.12.0 milestone Feb 2, 2021
@ralfgehrer ralfgehrer requested review from a team February 2, 2021 11:12
harambasicluka
harambasicluka approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! :)
IMO the contentDescription can be removed.

...a-Warn-App/src/main/java/de/rki/coronawarnapp/statistics/ui/StatisticsExplanationFragment.kt Show resolved Hide resolved
@harambasicluka harambasicluka self-assigned this Feb 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@axelherbstreith
Copy link
Contributor

axelherbstreith commented Feb 2, 2021 •
edited

Looking good on Samsung S8 but somehow the app crashes when opening the screen on my P30... not sure what causes this

Never mind, language was set to English on the Huawei Device, which is not supported atm

@BMItr BMItr self-assigned this Feb 2, 2021
BMItr
BMItr approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Nexus 5x and Samsung S20. looking good 👌
PS: I also checked on a P20 Device, but was also working as expected (no crash). But I have no P30

@ralfgehrer
Copy link
Contributor Author

tested on Nexus 5x and Samsung S20. looking good 👌
PS: I also checked on a P20 Device, but was also working as expected (no crash). But I have no P30

The crash was due to English language settings. This will updated with the upcoming Translation Delivery. @axelherbstreith could validate it with German language settings.

@harambasicluka harambasicluka merged commit 0fdd78c into release/1.12.x Feb 2, 2021
@harambasicluka harambasicluka deleted the fix/dev_percentage_sign branch February 2, 2021 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harambasicluka harambasicluka harambasicluka approved these changes

@BMItr BMItr BMItr approved these changes

@axelherbstreith axelherbstreith axelherbstreith approved these changes

Assignees

@BMItr BMItr

@harambasicluka harambasicluka

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ralfgehrer @axelherbstreith @BMItr @harambasicluka