-
Notifications
You must be signed in to change notification settings - Fork 499
Fix exposure logging progress circle inconsistencies. (EXPOSUREAPP-1835) #2297
Conversation
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/view/CircleProgress.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Forgot about that. I'll add it there as well. Edit: Addressed your comment. The progress color should now be rendered correctly everywhere, including the risk cards. |
@SamuraiKek after your changes: |
Yes, I've intentionally done this because when bluetooth is turned off, the risk calculation becomes restricted. There isn't really a design guidline for this case, maybe we should ask somebody about it? I can quickly change it to the blue tint. @ralfgehrer, @harambasicluka, what do you think? |
IMHO, the progress should be shown. Otherwise, the circle does not make much sense, does it? |
Alright, the same behaviour was happening when the location is disabled so I'll take care of that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , tested latest changes on Samsung S8 while location and bluetooth on/off.
Kudos, SonarCloud Quality Gate passed! |
This PR makes the circle progress in line with the iOS one. Adding the x/14 days inside the circle and changing the progress color depending on the state of the exposure logging.
How to test: