This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Adjust device time test setting (DEV) #2316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of faking the "disable-device-time-check" which won't work for SafetyNet, we now fake the time offset to be within the acceptable delta.
When activating fake time and traveling one day into the future, I receive the following exception on the "Casual" SafetyNet Report |
Kudos, SonarCloud Quality Gate passed! |
ralfgehrer
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified with @d4rken.
- Launch app
- check test menu --> Remote config - isDeviceTimeCorrec should be true
- enable fake time
- travel > 24h
- check SafetyNet Report "Casually" --> Requirements passed
LukasLechnerDev
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Device has correct time
- Reset App
- Do Onboarding
- TestMenu: Create SafetyNet Report
=> casual verification fails with "Time since first reliable timestamp < 24h"
=====
- Enable "Fake correct device time"
- time travel 24h into the future
- TestMenu: Create SafetyNet Report
=> casual verification: "Requirements passed"
=====
- time travel only 23h in the future
- TestMenu: Create SafetyNet Report
=> casual verification fails with "Time since first reliable timestamp < 24h"
=> Works as expected.
- Tests also look good and verify that the time can't be faked in production builds.
- One Suggestion would be to describe the new switch a bit better in the Developer Menu. e.g. by adding "This allows time travelling while still getting positive device time checks" or something like that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
author merge
PR to be merged by author
maintainers
Tag pull requests created by maintainers
prio
PRs to review first.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of faking the "disable-device-time-check" which won't work for SafetyNet,
we now fake the time offset to be within the acceptable delta.
Testing