Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix PPA Submission Endpoint Return Type (DEV) #2366

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

kolyaopahle
Copy link
Contributor

@kolyaopahle kolyaopahle commented Feb 16, 2021

Description

This PR implements a change in the PPA Specs where the /version/v1/android/dat endpoint will now return an errorCode instead of an errorState

…h changed spec

Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers labels Feb 16, 2021
@kolyaopahle kolyaopahle added this to the 1.13.0 milestone Feb 16, 2021
@kolyaopahle kolyaopahle requested a review from a team February 16, 2021 09:22
@kolyaopahle kolyaopahle changed the title changed errorState to errorCode in DataDonationAnalyticsApiV1 to matc… Fix PPA Submission Endpoint Return Type (EXPOSUREAPP-FREESTYLE) Feb 16, 2021
Copy link
Member

@mlenkeit mlenkeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolyaopahle so there's no occurrence of errorState anymore? Also not for EDUS?

@kolyaopahle
Copy link
Contributor Author

@kolyaopahle so there's no occurrence of errorState anymore? Also not for EDUS?

i'm 9/10 confident yes 😅

image

@harambasicluka harambasicluka self-assigned this Feb 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer self-assigned this Feb 16, 2021
@harambasicluka harambasicluka merged commit 3dfc92a into release/1.13.x Feb 16, 2021
@harambasicluka harambasicluka deleted the fix/proper-error-handling-in-analytics branch February 16, 2021 10:22
@harambasicluka harambasicluka changed the title Fix PPA Submission Endpoint Return Type (EXPOSUREAPP-FREESTYLE) Fix PPA Submission Endpoint Return Type (DEV) Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants