This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
PPA Collect exposure windows (EXPOSUREAPP-4819) #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/datadonation/analytics/modules/exposurewindows/NewExposureWindowsDonor.kt
harambasicluka
changed the title
chiljamgossow
changed the title
d4rken
reviewed
Feb 17, 2021
...awarnapp/datadonation/analytics/modules/exposurewindows/AnalyticsExposureWindowRepository.kt
Outdated
Show resolved
Hide resolved
d4rken
reviewed
Feb 17, 2021
...rc/main/java/de/rki/coronawarnapp/datadonation/analytics/modules/exposurewindows/Database.kt
Outdated
Show resolved
Hide resolved
d4rken
reviewed
Feb 17, 2021
...p/src/main/java/de/rki/coronawarnapp/datadonation/analytics/modules/exposurewindows/Model.kt
Outdated
Show resolved
Hide resolved
d4rken
reviewed
Feb 17, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/risk/RiskLevelTask.kt
Outdated
Show resolved
Hide resolved
kolyaopahle
previously approved these changes
Feb 24, 2021
mtwalli
reviewed
Feb 24, 2021
...coronawarnapp/datadonation/analytics/modules/exposurewindows/AnalyticsExposureWindowDonor.kt
Outdated
Show resolved
Hide resolved
...coronawarnapp/datadonation/analytics/modules/exposurewindows/AnalyticsExposureWindowDonor.kt
Show resolved
Hide resolved
...nawarnapp/datadonation/analytics/modules/exposurewindows/AnalyticsExposureWindowDonorTest.kt
Outdated
Show resolved
Hide resolved
...app/datadonation/analytics/modules/exposurewindows/AnalyticsExposureWindowsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
|
Tested it on Samsung S8 , data is collected and submitted |
d4rken
previously approved these changes
Feb 24, 2021
...rnapp/datadonation/analytics/modules/exposurewindows/AnalyticsExposureWindowsDatabaseTest.kt
Outdated
Show resolved
Hide resolved
kolyaopahle
previously approved these changes
Feb 24, 2021
chiljamgossow
dismissed stale reviews from kolyaopahle, d4rken, and mtwalli
via
e4cf646
chiljamgossow
force-pushed
the
feature/4819-exposure-window
branch
from
2b01c73
to
e4cf646
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mtwalli
approved these changes
Feb 24, 2021
ralfgehrer
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech spec: https://github.com/corona-warn-app/cwa-app-tech-spec/blob/40e00dfd0e4544bdf05a2ae83fa7123af86b9438/docs/spec/data-donation-client-ppa.md#new-exposure-windows
New exposure windows are stored on a new database. Primary key is a sha256Hash calculated on the string generated by the corresponding data class. For reported exposure windows only the hash value is stored.
A db rollback is performed in case the submission fails.
Stale data is being deleted on each donation.
How to test with test menu: