Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

PPA Exposure Risk Metadata mostRecentDateAtRiskLevel not correct (EXPOSUREAPP-5202) #2390

Merged
merged 5 commits into from Feb 17, 2021
Merged

PPA Exposure Risk Metadata mostRecentDateAtRiskLevel not correct (EXPOSUREAPP-5202) #2390

merged 5 commits into from Feb 17, 2021

Conversation

kolyaopahle
Copy link
Contributor

Description

This PR resolves an issue with the ExposureRiskMetadataDonor where mostRecentDateAtRiskLevel would report the calculation timestamp instead of the proper date

Steps to reproduce

  1. Install app and complete onboarding
  2. Use tester menu to generate analytics
  3. Check if the proper timestamp is submitted

@kolyaopahle
Fixed an issue in ExposureRiskMetadataDonor where mostRecentDateAtRis…
e0be3dc 
…kLevel was set to the calculation timestamp instead of the encounter timestamp

Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle
Updated ExposureRiskMetadataDonorTest to reflect new data
a071057 
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers prio PRs to review first. labels Feb 17, 2021
@kolyaopahle kolyaopahle added this to the 1.13.0 milestone Feb 17, 2021
@kolyaopahle kolyaopahle requested a review from a team February 17, 2021 09:41
@chiljamgossow chiljamgossow self-assigned this Feb 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka self-assigned this Feb 17, 2021
harambasicluka
harambasicluka approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on a Pixel 3 (Android 10) with the hosted mock server.

@ralfgehrer ralfgehrer self-assigned this Feb 17, 2021
@ralfgehrer ralfgehrer merged commit 9662460 into release/1.13.x Feb 17, 2021
@ralfgehrer ralfgehrer deleted the fix/5202-wrong-value-used-in-date-at-risk-level branch February 17, 2021 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@harambasicluka harambasicluka harambasicluka approved these changes

Assignees

@ralfgehrer ralfgehrer

@chiljamgossow chiljamgossow

@harambasicluka harambasicluka

Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kolyaopahle @ralfgehrer @harambasicluka @chiljamgossow