Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact Journal Day Screen Accessibility (EXPOSUREAPP-5134) #2391

Merged

Conversation

axelherbstreith
Copy link
Contributor

Small PR that changes the announcement of the Floating Action Button in the contact journal day screen when exploring by touch.
Changed from "Ort" to "Ort hinzufügen" e.g. "Person" to "Person hinzufügen"

To test the changes, activate TalkBack and navigate to the day screen of the contact journal. Explore Floating Action Button by touch.

@axelherbstreith axelherbstreith added maintainers Tag pull requests created by maintainers accessibility Accessibility issues labels Feb 17, 2021
@axelherbstreith axelherbstreith added this to the 1.14.0 milestone Feb 17, 2021
@axelherbstreith axelherbstreith requested review from a team February 17, 2021 11:55
Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 talk back worked on pixel 5 (Android 11)

kolyaopahle
kolyaopahle previously approved these changes Feb 17, 2021
Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 talk back worked on pixel 5 (Android 11)

@LukasLechnerDev LukasLechnerDev self-assigned this Feb 17, 2021
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Samsung S20+, Android 11.

One small remark.

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@axelherbstreith axelherbstreith merged commit fefae56 into release/1.14.x Feb 18, 2021
@axelherbstreith axelherbstreith deleted the fix/5134-contact-journal-edit-annoucement branch February 18, 2021 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Accessibility issues maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants