This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Reduce timeout to 5 sec (EXPOSUREAPP-5196) #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
added
bug
mtwalli
changed the title
|
LGTM, tested on a Pixel3. Won't approve it until we have a decision how to proceed. |
|
Kudos, SonarCloud Quality Gate passed! |
ralfgehrer
approved these changes
Feb 18, 2021
harambasicluka
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue when Broadcast receiver is not triggered after requesting TEK keys using new Google APIs
Before 20 sec timeout it gives the user the ability to click the button many times ,while DefaultTEKProvider is waiting to timeout after 20 sec if receiver did not deliver the keys
Reducing timeout to 5 sec will timeout quickly with an error which then will fallback to old APIs to get the keys
Show Progress dialog while retrieving the keys to give the user indication that there's something going in the background and prevent multiple many clicks