Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

ExposureHistory - high risk by multiple low risk (EXPOSUREAPP-3515) #2397

Merged
merged 18 commits into from
Feb 23, 2021
Merged

ExposureHistory - high risk by multiple low risk (EXPOSUREAPP-3515) #2397

merged 18 commits into from
Feb 23, 2021

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Feb 17, 2021 •
edited

This PR addresses Exposureapp-3515 (high risk caused by multiple low risk encounters).

Features:

  • provide special high risk inside the contact diary (caused by low risks)
  • ViewModel test for contact diary

todo (done):

  • fix tests
  • testmenu item

how to test:

  • go to testmenu
  • ENF v2 Calculation
  • set to Increased_Risk_Due_low_risk_encounter & calculate Risk Level
  • Go to the MainFragment and open the Contact Diary
  • Check the Exposure Entries for the new item

Screenshot:
image

@BMItr BMItr requested review from a team February 17, 2021 18:36
@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Feb 17, 2021
@BMItr BMItr added this to the 1.14.0 milestone Feb 17, 2021
@BMItr BMItr marked this pull request as draft February 19, 2021 12:19
@dsarkar dsarkar mentioned this pull request Feb 22, 2021
Open
@BMItr BMItr marked this pull request as ready for review February 22, 2021 16:00
@jurajkusnier jurajkusnier self-assigned this Feb 23, 2021
mlenkeit
mlenkeit previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@mlenkeit mlenkeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a functional perspective!

@ralfgehrer ralfgehrer added text change PRs with text changes. prio PRs to review first. labels Feb 23, 2021
jurajkusnier
jurajkusnier previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

janetback
janetback previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

chris-cwa
chris-cwa previously approved these changes Feb 23, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.6% 69.6% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 36d1f99 into release/1.14.x Feb 23, 2021
@ralfgehrer ralfgehrer deleted the feature/3515-advanced-risk-journal branch February 23, 2021 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@chris-cwa chris-cwa chris-cwa approved these changes

@mlenkeit mlenkeit mlenkeit left review comments

@janetback janetback janetback left review comments

Assignees

@jurajkusnier jurajkusnier

@chris-cwa chris-cwa

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BMItr @ralfgehrer @mlenkeit @jurajkusnier @janetback @chris-cwa @harambasicluka