Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

PPA - Enhance dev menu (EXPOSUREAPP-5215) #2400

Merged
merged 8 commits into from
Feb 18, 2021
Merged

PPA - Enhance dev menu (EXPOSUREAPP-5215) #2400

merged 8 commits into from
Feb 18, 2021

Conversation

kolyaopahle
Copy link
Contributor

Description

This PR adds the ability to skip the 24H SafetyNet check during PPA and Survey submission
It also adds all errors during PPA Submission to the error reporter

Steps to reproduce

  1. Fresh App install
  2. Try to do a Analytics Submission (should fail with SafetyNet exception)
  3. Enable the SafetyNet Skip
  4. Submit again (Should succeed)
  5. Check Error reporter for any errors

@kolyaopahle
Added the ability to skip the CWASafetyNet 24H check
bce846c 
Added reportProblem call to Analytics error handling to provide testers with a way to inspect PPA Errors

Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle
Fixed CWASafetyNetTest
c2fa00a 
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers prio PRs to review first. labels Feb 18, 2021
@kolyaopahle kolyaopahle added this to the 1.13.0 milestone Feb 18, 2021
@kolyaopahle kolyaopahle requested a review from a team February 18, 2021 10:24
@d4rken d4rken self-requested a review February 18, 2021 11:01
@d4rken d4rken self-assigned this Feb 18, 2021
BMItr
BMItr approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@BMItr BMItr self-assigned this Feb 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 0e01dae into release/1.13.x Feb 18, 2021
@ralfgehrer ralfgehrer deleted the feature/5215-ppa-dev-ui-enhance branch February 18, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@d4rken d4rken

@BMItr BMItr

Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kolyaopahle @d4rken @BMItr @ralfgehrer @harambasicluka