Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Don't additionally base64 encode the nonce (DEV) #2410

Merged
merged 5 commits into from
Feb 18, 2021
Merged

Don't additionally base64 encode the nonce (DEV) #2410

merged 5 commits into from
Feb 18, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Feb 18, 2021

No description provided.

@d4rken d4rken added maintainers Tag pull requests created by maintainers prio PRs to review first. labels Feb 18, 2021
@d4rken d4rken added this to the 1.13.0 milestone Feb 18, 2021
@d4rken d4rken requested a review from a team February 18, 2021 15:15
@mlenkeit mlenkeit self-requested a review February 18, 2021 15:31
BMItr
BMItr previously approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on pixel 2. lgtm

mlenkeit
mlenkeit approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@mlenkeit mlenkeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it against the mock server and INT and the nonce check passed on both!

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 50d661f into release/1.13.x Feb 18, 2021
@ralfgehrer ralfgehrer deleted the fix/DEV-dont-base64-encode-nonce branch February 18, 2021 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mlenkeit mlenkeit mlenkeit approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@mlenkeit mlenkeit

@BMItr BMItr

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d4rken @mlenkeit @BMItr @ralfgehrer