This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Improve analytics error handling (DEV) #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontinue. On tester builds log these background issues in the bug reporter.
d4rken
added
maintainers
ralfgehrer
approved these changes
Feb 18, 2021
jurajkusnier
approved these changes
Feb 19, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a bug in a single data donation module, we don't want to abort the process and we do want the modules to have a chance to cleanup their state instead of just throwing the exception and leaving everyone hanging.
This change catches the exceptions logs them and lets the process continue, talked with @mlenkeit and continuing with the data we have is the desired behavior.
For tester builds we log this into the error tool such that testers can easily check if something went wrong without having to parse the log.
Testing