Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix endless uploading progress (EXPOSUREAPP-5237) #2416

Merged
merged 5 commits into from
Feb 19, 2021
Merged

Fix endless uploading progress (EXPOSUREAPP-5237) #2416

merged 5 commits into from
Feb 19, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Feb 18, 2021

  • Hide Progress dialog while leaving the last screen in submission flow.
  • To avoid having endless progress

@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers labels Feb 18, 2021
@mtwalli mtwalli added this to the 1.13.0 milestone Feb 18, 2021
@mtwalli mtwalli requested a review from a team February 18, 2021 17:42
@ralfgehrer ralfgehrer added the prio PRs to review first. label Feb 18, 2021
@ralfgehrer ralfgehrer self-assigned this Feb 19, 2021
ralfgehrer
ralfgehrer approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Pixel (Android 10)

@LukasLechnerDev LukasLechnerDev self-assigned this Feb 19, 2021
LukasLechnerDev
LukasLechnerDev approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 557b88b into release/1.13.x Feb 19, 2021
@mtwalli mtwalli deleted the fix/5237-endless-progress branch February 19, 2021 09:45
@mtwalli mtwalli mentioned this pull request Mar 5, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

Assignees

@ralfgehrer ralfgehrer

@LukasLechnerDev LukasLechnerDev

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @ralfgehrer @LukasLechnerDev @harambasicluka