Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Enhance screenshots-FTL(EXPOSUREAPP-5250) #2426

Merged
merged 19 commits into from
Feb 22, 2021
Merged

Enhance screenshots-FTL(EXPOSUREAPP-5250) #2426

merged 19 commits into from
Feb 22, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Feb 20, 2021 •
edited

  • Run screenshots 馃摳 tests on Firebase Test Lab
  • Refactor screenshots logic to work with both fastlane (locally) and Firebase Test Lab
  • We can always switch at anytime with less effort

Outcome

  • Quick and reliable screenshots job
  • High quality screenshots (No blank anymore)

Changes

  • No html file to display the results 馃Ь
  • Tests tab shows number of tests combined for both locales (DE, EN) = 96 Tests (In case. something went wrong, you would still know)
  • Screenshots 馃柤 and other artifacts (Logs + test_result) are zipped together.

Build Link

Enjoy 馃槈 release builds 馃彮 馃殌

@mtwalli mtwalli added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers prio PRs to review first. labels Feb 20, 2021
@mtwalli mtwalli added this to the 1.13.0 milestone Feb 20, 2021
@mtwalli mtwalli requested a review from a team February 20, 2021 16:07
@mtwalli mtwalli mentioned this pull request Feb 20, 2021
Closed
@d4rken d4rken self-assigned this Feb 22, 2021
@d4rken d4rken self-requested a review February 22, 2021 09:13
harambasicluka
harambasicluka reviewed Feb 22, 2021
View reviewed changes
Corona-Warn-App/src/debug/AndroidManifest.xml
@@ -15,4 +15,8 @@
android:name="android.permission.CHANGE_CONFIGURATION"
tools:ignore="ProtectedPermissions" />

<application
android:requestLegacyExternalStorage="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Is it visible to the user as permission in the playstore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed to avoid new storage api restrictions in Android 29, So I can save screenshots on sdcard/... it is the path where firebase can pull screenshots from according to their docs. [or the only path that really worked for me :)]
https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run#--directories-to-pull.
AND it is not affecting end user at all. it is just debug builds as you can see the link of the file 猬嗭笍 /debug/AndroidManifest.xml

ralfgehrer
ralfgehrer approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer that we lose fastlane's HTML overview, but well.

@ralfgehrer ralfgehrer self-assigned this Feb 22, 2021
d4rken
d4rken approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged for 1.13, but maybe we do a follow up for 1.14?

Corona-Warn-App/src/androidTest/java/testhelpers/ScreenShotter.kt Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ralfgehrer ralfgehrer merged commit 6b3ae70 into release/1.13.x Feb 22, 2021
@ralfgehrer ralfgehrer deleted the fix/5250-enhance-screenshots branch February 22, 2021 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harambasicluka harambasicluka harambasicluka left review comments

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@d4rken d4rken d4rken approved these changes

Assignees

@ralfgehrer ralfgehrer

@d4rken d4rken

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @ralfgehrer @d4rken @harambasicluka