Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

FIX: No PPA submission in background over 36+ hours (EXPOSUREAPP-5286) #2430

Merged
merged 8 commits into from
Feb 22, 2021

Conversation

kolyaopahle
Copy link
Contributor

@kolyaopahle kolyaopahle commented Feb 22, 2021

Description

This PR changes a few values in the PPA Worker Scheduling logic to combat huge initial execution delays and provide a more testable experience

Note that this does not influence the repeat of submissions every 24Hours afterwards, these should still happen as usual.

Steps to reproduce

  1. Install App and consent to analytics donation
  2. Wait 24 Hours (or check logcat for actual analytics scheduling delay)
  3. An Analytics donation should have been triggered in the background

…ication to make sure scheduling also happens on first app launch

Removed the inital 24 Hours start delay offset from the DataDonationAnalyticsScheduler, a random delay between 0 and 24 Hours is still generated

Signed-off-by: Kolya Opahle <k.opahle@sap.com>
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers prio PRs to review first. author merge PR to be merged by author labels Feb 22, 2021
@kolyaopahle kolyaopahle added this to the 1.13.0 milestone Feb 22, 2021
@kolyaopahle kolyaopahle requested a review from a team February 22, 2021 12:49
@kolyaopahle kolyaopahle removed the author merge PR to be merged by author label Feb 22, 2021
@mtwalli mtwalli self-assigned this Feb 22, 2021
@ralfgehrer ralfgehrer self-assigned this Feb 22, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d4rken d4rken self-assigned this Feb 22, 2021
@ralfgehrer ralfgehrer merged commit 5d9e950 into release/1.13.x Feb 22, 2021
@ralfgehrer ralfgehrer deleted the fix/5286-ppa-scheduling-tweaks branch February 22, 2021 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants