This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add network connected constraint to DataDonationAnalyticsWorker (EXPOSUREAPP-5286) #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
kolyaopahle
added
backend
| @@ -25,5 +27,11 @@ class DataDonationAnalyticsWorkBuilder @Inject constructor() { | |||
| BackgroundConstants.BACKOFF_INITIAL_DELAY, | |||
| TimeUnit.MINUTES | |||
| ) | |||
| .setConstraints(buildConstraints()) | |||
There was a problem hiding this comment.
Would it make sense to add a log if the worker wasn't started due to the network constraint?
There was a problem hiding this comment.
I'm not sure if we can, the work is scheduled by the WorkManager api and if there is no network connection the worker is simply not spawned, i don't think we get any kind of callback
There was a problem hiding this comment.
we could maybe remove the constraint and do the check inside of the worker ourselves but i think this kind of defeats the purpose of the work manager in the first place
mtwalli
approved these changes
Feb 22, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a network connected constraint to the work builder of the DataDonationAnalyticsWorker as we cannot proceed with analytics donation without a network connection there is no need to enqueue work in that case
Steps to reproduce