Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Skip consent screen on subsequent survey participations (EXPOSUREAPP-5278) #2433

Conversation

LukasLechnerDev
Copy link
Contributor

When the user has already granted his consent to participate in the survey for his current high-risk state, and the app has successfully authorized an OTP, subsequent clicks on the "Zur Befragung" Button of the Survey Card in the high-risk detail screen should lead the user directly to the survey URL in the browser instead of to the consent screen again.

The user should only see the consent screen again when he wants to participate in a survey when he gets a new high-risk state.

Testing:

  • Trigger high-risk state
  • Click on "Zur Befragung" in Survey Card
  • Consent Screen should show up
  • Grant consent to authorize OTP
  • Survey should open in the Browser
  • Click again on "Zur Befragung" in the survey card
  • Browser with survey should be opened instead of the Consent Screen
  • Trigger new high-risk state (trigger low risk and then high risk)
  • Click on "Zur Befragung" in the card should show consent screen again
  • If the current fake date of the device is in the same month as when the first OTP was authenticated, the "Only one participation per month" error should be shown, otherwise, the user gets to the survey and subsequent clicks on "Zur Befragung" should navigate him directly to the browser again

@LukasLechnerDev LukasLechnerDev added the maintainers Tag pull requests created by maintainers label Feb 22, 2021
@LukasLechnerDev LukasLechnerDev added this to the 1.13.0 milestone Feb 22, 2021
@LukasLechnerDev LukasLechnerDev requested a review from a team February 22, 2021 14:51
@BMItr BMItr self-assigned this Feb 22, 2021
@BMItr
Copy link
Contributor

BMItr commented Feb 22, 2021

nothing critical. lgtm 👌

BMItr
BMItr previously approved these changes Feb 22, 2021
chris-cwa
chris-cwa previously approved these changes Feb 22, 2021
Copy link
Contributor

@chris-cwa chris-cwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LukasLechnerDev LukasLechnerDev dismissed stale reviews from chris-cwa and BMItr via 864218d February 22, 2021 15:25
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@LukasLechnerDev LukasLechnerDev merged commit fd69ed4 into release/1.13.x Feb 22, 2021
@LukasLechnerDev LukasLechnerDev deleted the feature/5278-Skip-consent-screen-on-subsequent-survey-participations branch February 22, 2021 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants