Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Resize diary home screen attributes when empty (DEV) #2441

Merged

Conversation

SamuraiKek
Copy link
Contributor

Small fix to hide the attributes textview when there aren't any attributes selected as it was causing unnecessary vertical space.

…en-empty

# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/contactdiary/ui/overview/adapter/ContactDiaryOverviewNestedAdapter.kt
@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Feb 23, 2021
@SamuraiKek SamuraiKek added this to the 1.14.0 milestone Feb 23, 2021
@SamuraiKek SamuraiKek requested review from a team February 23, 2021 12:27
@SamuraiKek SamuraiKek changed the base branch from main to release/1.14.x February 23, 2021 12:27
@axelherbstreith axelherbstreith self-assigned this Feb 23, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka self-assigned this Feb 23, 2021
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on a Pixel 3 (Android 11).

@harambasicluka harambasicluka changed the title Resize diary home screen attributes when empty Resize diary home screen attributes when empty (DEV) Feb 23, 2021
@harambasicluka harambasicluka merged commit 2b97906 into release/1.14.x Feb 23, 2021
@harambasicluka harambasicluka deleted the fix/4741-diary-extension-resize-when-empty branch February 23, 2021 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants