This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Hide progress dialog on missing consent from both Google and App (EXPOSUREAPP-5320) #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
jurajkusnier
approved these changes
Feb 23, 2021
ralfgehrer
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix:
1- Open the App and proceed with QR code scanning
2- Disallow Google consent
3- Scan a positive test
4- Proceed to sharing
5- Click on Consent button and disallow our consent flag
6- return back and try to share the keys
7- the progress dialog will be shown forever
After:
Dialog will hide if consent has not been given