Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Button Text Color Adaption (DEV) #2447

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

axelherbstreith
Copy link
Contributor

This PR adapts the text color of a button in light mode when it is disabled from white to gray for better visibility.

imgo-1
imgo

@axelherbstreith axelherbstreith added the maintainers Tag pull requests created by maintainers label Feb 23, 2021
@axelherbstreith axelherbstreith added this to the 1.14.0 milestone Feb 23, 2021
@axelherbstreith axelherbstreith requested a review from a team February 23, 2021 15:49
@mtwalli
Copy link
Contributor

mtwalli commented Feb 23, 2021

Tested it on S8 , Android 9 lgtm

@mtwalli mtwalli self-assigned this Feb 23, 2021
@harambasicluka harambasicluka self-assigned this Feb 23, 2021
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Pixel 3 (Android 11).

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@axelherbstreith axelherbstreith merged commit 03f13ba into release/1.14.x Feb 23, 2021
@axelherbstreith axelherbstreith deleted the fix/dev-contact-journal-button-color branch February 23, 2021 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants