Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add option to clear text fields when adding/editing persons/locations (DEV) #2454

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Feb 24, 2021

The text fields on iOS had the "clear text" option while we don't, can't let 🍏 💯 us.

  • Add app:endIconMode="clear_text" to person/location add/edit text fields.
  • Shorten overly long layout ids

Screenshot from 2021-02-24 13-31-29

@d4rken d4rken added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels Feb 24, 2021
@d4rken d4rken added this to the 1.14.0 milestone Feb 24, 2021
@d4rken d4rken requested a review from a team February 24, 2021 12:39
@LukasLechnerDev LukasLechnerDev self-assigned this Feb 24, 2021
Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Tested on Samsung Galaxy S8 (Android 10)

Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mtwalli mtwalli self-assigned this Feb 24, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Feb 24, 2021

Tested on Samsung S8 Android 9, it flickers sometimes.

@mtwalli
Copy link
Contributor

mtwalli commented Feb 24, 2021

device-2021-02-24-142010.mp4

@axelherbstreith axelherbstreith self-assigned this Feb 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 40e3686 into release/1.14.x Feb 24, 2021
@ralfgehrer ralfgehrer deleted the feature/DEV-diary-text-clear branch February 24, 2021 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants