Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Update contact journal screenshots (DEV) #2458

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Update contact journal screenshots (DEV) #2458

merged 3 commits into from
Feb 24, 2021

Conversation

jurajkusnier
Copy link
Contributor

Update mock data for contact journal screenshots

@jurajkusnier jurajkusnier added the maintainers Tag pull requests created by maintainers label Feb 24, 2021
@jurajkusnier jurajkusnier added this to the 1.13.0 milestone Feb 24, 2021
@jurajkusnier jurajkusnier requested a review from a team February 24, 2021 13:53
@ralfgehrer
Copy link
Contributor

ralfgehrer commented Feb 24, 2021 •
edited

Thx. If we were to enable the firebase_screenshots CI task on this branch, we could easily validate the fix and won't need to build an RC.

ralfgehrer
ralfgehrer previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. LGTM

@ralfgehrer ralfgehrer self-assigned this Feb 24, 2021
@ralfgehrer ralfgehrer added the prio PRs to review first. label Feb 24, 2021
@LukasLechnerDev LukasLechnerDev self-assigned this Feb 24, 2021
@harambasicluka
Copy link
Contributor

Screenhots

mtwalli
mtwalli reviewed Feb 24, 2021
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@mtwalli mtwalli self-assigned this Feb 24, 2021
LukasLechnerDev
LukasLechnerDev approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct text "Diese müssen nicht in Zusammenhang mit den von Ihnen erfassten Personen und Orten stehen." is now added to a high or low risk in our contact journal, so LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ralfgehrer ralfgehrer merged commit 87a17bf into release/1.13.x Feb 24, 2021
@ralfgehrer ralfgehrer deleted the fix/DEV-update-contact-diary-screenshots branch February 24, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harambasicluka harambasicluka harambasicluka left review comments

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

@mtwalli mtwalli mtwalli approved these changes

Assignees

@ralfgehrer ralfgehrer

@LukasLechnerDev LukasLechnerDev

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jurajkusnier @ralfgehrer @harambasicluka @LukasLechnerDev @mtwalli