Improve screenshots testing(DEV)

[mtwalli]

It looks like Screenshots is becoming an important feature for our project.
A question was raised by @LukasLechnerDev here

on how to test that without adding firebase_screenshots to the flow?

I thought 💭 that might we need a solution that we can use during the implementation phase before even pushing to GitHub.
Here it is:

• Added a flag so you can you execute the test locally from Android Studio or command line

How?

1- From Android Studio edit the configuration and your test parameters:

2- From the command line:

$ adb shell am instrument -w -m -e androidStudioMode true -e annotation testhelper.Screenshot   -e debug false -e class 'de.rki.coronawarnapp.ui.main.MainActivityTest' de.rki.coronawarnapp.test.test/testhelpers.TestApplicationUIRunner

[LukasLechnerDev]

Hi! Thanks for this! This is really helpful when extending / adapting our screenshots.

I have an idea how we could further improve this so that we don't need to change actual code during development:
We could add an instrumentation param like "testMode" in the Run Configuration of a test or TestClass in Android Studio whenever we want to store a screenshot on the sdcard:

Then, in our function that takes the screenshot, we could have something like this:

So without this Instrumentation param, our screenshots are taken as usual, but when a developer sets the param, they are stored on the sdcard.

What do you think?

[mtwalli]

Hi! Thanks for this! This is really helpful when extending / adapting our screenshots.

I have an idea how we could further improve this so that we don't need to change actual code during development:
We could add an instrumentation param like "testMode" in the Run Configuration of a test or TestClass in Android Studio whenever we want to store a screenshot on the sdcard:

Then, in our function that takes the screenshot, we could have something like this:

So without this Instrumentation param, our screenshots are taken as usual, but when a developer sets the param, they are stored on the sdcard.

What do you think?

This was my first thought, if you like this way, I can simplify this even further. Wait for my commit below ⬇️

[LukasLechnerDev]

Yes, I like it very much 👍 ! We also have to write it in our Wiki so the other Devs know this "trick" too 😉

[mtwalli]

Yes, I like it very much 👍 ! We also have to write it in our Wiki so the other Devs know this "trick" too 😉

Done: https://teams.microsoft.com/l/entity/com.microsoft.teamspace.tab.wiki/tab::32332847-46cb-4995-a3eb-e183b8c68f28?context=%7B%22subEntityId%22%3A%22%7B%5C%22pageId%5C%22%3A6%2C%5C%22sectionId%5C%22%3A66%2C%5C%22origin%5C%22%3A2%7D%22%2C%22channelId%22%3A%2219%3Ac51bf302889a44e28119b0efc59b8f7d%40thread.tacv2%22%7D&tenantId=42f7676c-f455-423c-82f6-dc2d99791af7

[LukasLechnerDev]

LGTM! Tested it for the screenshot adaptions for the contact diary extension and works really nice. Great PR :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information