Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

FIX: PPA delta onboarding (EXPOSUREAPP-5381) #2469

Merged
merged 4 commits into from
Feb 25, 2021
Merged

FIX: PPA delta onboarding (EXPOSUREAPP-5381) #2469

merged 4 commits into from
Feb 25, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

Fixing annoying delta onboarding screen for PPA.

How to test:

  1. Install 1.12.x
  2. Install this branch
  3. Press any button on "New features" screen
  4. Check PPA delta onboarding screen
  5. VERSION_MINOR++ in gradle.properties
  6. Install
  7. After "New features" should be no PPA delta onboarding screen

Additional checks: try to use hardware buttons, close button and buttons on bottom on each screen.

@AlexanderAlferov AlexanderAlferov added maintainers Tag pull requests created by maintainers Fix 1.13 Fix is planned for 1.13 labels Feb 25, 2021
@ralfgehrer ralfgehrer removed the Fix 1.13 Fix is planned for 1.13 label Feb 25, 2021
@ralfgehrer ralfgehrer added this to the 1.13.0 milestone Feb 25, 2021
@harambasicluka harambasicluka modified the milestones: 1.13.0, 1.13.2 Feb 25, 2021
@d4rken d4rken self-assigned this Feb 25, 2021
@BMItr BMItr self-assigned this Feb 25, 2021
@harambasicluka
Copy link
Contributor

Tested on a Pixel 3 (Android 11), works as described.

@harambasicluka harambasicluka added the prio PRs to review first. label Feb 25, 2021
d4rken
d4rken approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

39.5% 39.5% Coverage
0.0% 0.0% Duplication

BMItr
BMItr approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm 👌
tested on Pixel 2

@AlexanderAlferov AlexanderAlferov merged commit b18ef67 into release/1.13.x Feb 25, 2021
@AlexanderAlferov AlexanderAlferov deleted the fix/ppa-delta-onboarding branch February 25, 2021 17:27
@ralfgehrer ralfgehrer changed the title FIX: PPA delta onboarding FIX: PPA delta onboarding (EXPOSUREAPP-5381) Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@BMItr BMItr BMItr approved these changes

@harambasicluka harambasicluka Awaiting requested review from harambasicluka

Assignees

@d4rken d4rken

@BMItr BMItr

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlexanderAlferov @harambasicluka @d4rken @BMItr @ralfgehrer