This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Contact diary person and place with more than 250 letters can be saved (EXPOSUREAPP-5400) #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasLechnerDev
added
bug
…place-with-more-than-250-letters-can-be-saved
…place-with-more-than-250-letters-can-be-saved
ralfgehrer
reviewed
Feb 26, 2021
...src/main/java/de/rki/coronawarnapp/contactdiary/storage/entity/ContactDiaryLocationEntity.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Feb 26, 2021
...p/src/main/java/de/rki/coronawarnapp/contactdiary/storage/entity/ContactDiaryPersonEntity.kt
Show resolved
Hide resolved
…d-place-with-more-than-250-letters-can-be-saved' into fix/5400-Contact-diary-person-and-place-with-more-than-250-letters-can-be-saved
|
@SamuraiKek asked me to remove some unnecessary style items, see 👆 |
ralfgehrer
reviewed
Feb 26, 2021
...src/main/java/de/rki/coronawarnapp/contactdiary/storage/entity/ContactDiaryLocationEntity.kt
Show resolved
Hide resolved
BMItr
previously approved these changes
Feb 26, 2021
d4rken
reviewed
Feb 26, 2021
...p/src/main/java/de/rki/coronawarnapp/contactdiary/storage/entity/ContactDiaryPersonEntity.kt
Show resolved
Hide resolved
…place-with-more-than-250-letters-can-be-saved
…place-with-more-than-250-letters-can-be-saved
SamuraiKek
previously approved these changes
Feb 26, 2021
…d-place-with-more-than-250-letters-can-be-saved' into fix/5400-Contact-diary-person-and-place-with-more-than-250-letters-can-be-saved
LukasLechnerDev
dismissed stale reviews from SamuraiKek and BMItr
via
108b9bc
|
Clarified the I added another commit for that: 3f429aa |
|
Kudos, SonarCloud Quality Gate passed! |
SamuraiKek
approved these changes
Feb 26, 2021
ralfgehrer
approved these changes
Feb 26, 2021
ralfgehrer
deleted the
fix/5400-Contact-diary-person-and-place-with-more-than-250-letters-can-be-saved
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testers reported that it was possible to store more than 250 characters for names of persons and locations in our contact diary.
This fix now sets a maxLength to the input fields so that users can't even add more than 250 characters and also trims the string again before writing to the database.
I also applied this 250 character restriction to the email + phone fields of persons and locations.