This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Contact Journal Overview Screen Scrolling (DEV) #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the diary overview list modular and make the subheader scrollable by making it part of the list. Flatten layouts.
ralfgehrer
approved these changes
Feb 26, 2021
BMItr
approved these changes
Feb 26, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@axelherbstreith raised the issue in #2439 that the subheader text in the diary consumes valuable screen estate.
This initial attempt of making the whole screen scrolling was problematic due to the performance of nested layout scrolling.
This PR makes the subheader a list item like the other entries, by reusing the same modular adapter we have for the homescreen.
The overall layout nesting was slightly improved.
Check that the screen still looks correct and scrolls nicely.