Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove app shortcut during submission process (TAN) (EXPOSUREAPP-5425) #2493

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

jurajkusnier
Copy link
Contributor

The shortcut menu should not be visible if the submission process was started (from entering the positive test result screen until returning back to the home screen).

Testing

Install CWA, finish onboarding, check if the app shortcut is available.
Add positive TAN and immediately close the app before finishing the submission process. App shortcut shouldn't be available now. Finish the submission process and go back to the home screen. App shortcut should be available again.

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers labels Mar 1, 2021
@jurajkusnier jurajkusnier added this to the 1.14.0 milestone Mar 1, 2021
@jurajkusnier jurajkusnier requested a review from a team March 1, 2021 13:02
@ralfgehrer ralfgehrer added the prio PRs to review first. label Mar 1, 2021
@ralfgehrer ralfgehrer self-assigned this Mar 1, 2021
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Pixel (Android 10).

@LukasLechnerDev LukasLechnerDev self-assigned this Mar 1, 2021
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works on Samsung S20+.

@ralfgehrer ralfgehrer merged commit 6c3ec34 into release/1.14.x Mar 1, 2021
@ralfgehrer ralfgehrer deleted the fix/5425-tan_app_shortcut branch March 1, 2021 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants