Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Dialog runs forever (EXPOSUREAPP-5493) #2508

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 3, 2021

From the logs I see the callback when TEK is received is called ,but despite that the dialog was not hidden.
My best guess here it is a race condition where routeToScreen.postValue is navigating to the next screen and
showKeysRetrievalProgress.postValue never got the chance to have an effect.

Fix: showKeysRetrievalProgress.postValue is called before routeToScreen.postValue to guarantee it is called.

Logs section:

2021-03-02T19:16:45.202Z  D/TEKHistoryUpdater$updateHistoryAndTriggerCallback: onTEKAvailable(teks.size=1)
2021-03-02T19:16:45.203Z  I/AutoSubmission: updateMode(mode=MONITOR)
2021-03-02T19:16:45.207Z  V/SharedPreferencesImpl$EditorImpl: android.app.SharedPreferencesImpl@496ca1a:submission.user.activity.last changed to 2021-03-02T19:16:45.203Z
2021-03-02T19:16:45.211Z  V/SharedPreferencesImpl$EditorImpl: android.app.SharedPreferencesImpl@496ca1a:submission.auto.enabled changed to true
2021-03-02T19:16:45.212Z  V/AutoSubmission: scheduleWorker(): Creating periodic worker request for submission.
2021-03-02T19:16:45.229Z  D/AppInjector: Injecting SubmissionTestResultConsentGivenFragment{d21503f} (29a58653-0455-4dc5-814e-03cf0bd44616) id=0x7f090329}
2021-03-02T19:16:45.241Z  D/DefaultTEKHistoryProvider$getPreAuthTEKHistoryOrRequestPermissionOnV18: onTEKHistoryAvailable() -> permission were already available
2021-03-02T19:16:45.288Z  V/SubmissionTestResultConsentGivenViewModel: Initialized

@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers labels Mar 3, 2021
@mtwalli mtwalli added this to the 1.14.0 milestone Mar 3, 2021
@mtwalli mtwalli requested a review from a team March 3, 2021 10:44
@mtwalli mtwalli added the prio PRs to review first. label Mar 3, 2021
@ralfgehrer ralfgehrer self-assigned this Mar 3, 2021
@BMItr BMItr self-assigned this Mar 3, 2021
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm.
We should keep an eye on it checking whether the implementation is sufficent for the issue

@mtwalli mtwalli merged commit 0d5657e into release/1.14.x Mar 3, 2021
@mtwalli mtwalli deleted the fix/5493-dialog-runs-forever branch March 3, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants