Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Printing option (EXPOSUREAPP-5675) #2574

Merged
merged 7 commits into from
Mar 11, 2021
Merged

Printing option (EXPOSUREAPP-5675) #2574

merged 7 commits into from
Mar 11, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 11, 2021 •
edited

Support printing options as in design
Screenshot 2021-03-11 at 09 31 07

device-2021-03-11-093702.mp4

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 11, 2021
@mtwalli mtwalli added this to the 2.0.0 milestone Mar 11, 2021
@mtwalli mtwalli requested a review from a team March 11, 2021 08:38
@AlexanderAlferov AlexanderAlferov self-assigned this Mar 11, 2021
AlexanderAlferov
AlexanderAlferov approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Samsung S8.
Screenshot 2021-03-11 at 12 20 33

@BMItr BMItr self-assigned this Mar 11, 2021
BMItr
BMItr reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on pixel 2 (Android 11), working fine.
@mtwalli could you check lower android versions?
I made a quick test on Android 8.1 without success...

@mtwalli
Copy link
Contributor Author

mtwalli commented Mar 11, 2021

tested on pixel 2 (Android 11), working fine.
@mtwalli could you check lower android versions?
I made a quick test on Android 8.1 without success...

Did you get an error ? crash ? or ?

@BMItr
Copy link
Contributor

BMItr commented Mar 11, 2021

tested on pixel 2 (Android 11), working fine.
@mtwalli could you check lower android versions?
I made a quick test on Android 8.1 without success...

Did you get an error ? crash ? or ?

printing / Pdf mode was just not showing up

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

BMItr
BMItr approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with latest commits, now working on older devices.
Test successful for Pixel 2, Nexus 5x, Huawei P20.
code lgtm

@mtwalli mtwalli merged commit 13a58b2 into feature/5062-event-registration-main Mar 11, 2021
@mtwalli mtwalli deleted the feature/5675-printing-option branch March 11, 2021 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BMItr BMItr BMItr approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

Assignees

@BMItr BMItr

@AlexanderAlferov AlexanderAlferov

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtwalli @BMItr @AlexanderAlferov