This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Change screenshot data for contact diary (DEV) #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasLechnerDev
added
maintainers
harambasicluka
previously approved these changes
Mar 11, 2021
ralfgehrer
reviewed
Mar 11, 2021
ralfgehrer
approved these changes
Mar 11, 2021
harambasicluka
approved these changes
Mar 11, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our screenshots should have the following texts for the contact diary:
The pipeline will run
firebase_screenshots, so the screenshots are an artifact in CircleCI. You can take a look there to verify if the correct texts are displayed.Todo before merging:
firebase_screenshotagain