Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Encryption migration edge case handling (DEV) #2596

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Encryption migration edge case handling (DEV) #2596

merged 3 commits into from
Mar 12, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Mar 12, 2021

@jurajkusnier and me handled a few more edge cases after discussions on #2569

  • Handle errors during copy of data and still show the error reset dialog
  • Initialize migration early, before all other components are injected to prevent possible edge cases where a component may initialize and try to access the preference before migration.

Testing

Switch between 1.14 branch and this PR and read the start of logcat on app launch.

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Mar 12, 2021
@d4rken d4rken added this to the 1.15.0 milestone Mar 12, 2021
@d4rken d4rken requested review from jurajkusnier and a team March 12, 2021 11:45
@chris-cwa chris-cwa self-assigned this Mar 12, 2021
@ralfgehrer ralfgehrer self-assigned this Mar 12, 2021
ralfgehrer
ralfgehrer approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jurajkusnier
jurajkusnier approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LGTM
  • Migration works as expected

@sonarcloud
Copy link

sonarcloud bot commented Mar 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

1.9% 1.9% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit 68f7103 into release/1.15.x Mar 12, 2021
@ralfgehrer ralfgehrer deleted the fix/DEV-localdata-migration-tweaks branch March 12, 2021 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@jurajkusnier jurajkusnier jurajkusnier approved these changes

Assignees

@ralfgehrer ralfgehrer

@jurajkusnier jurajkusnier

@chris-cwa chris-cwa

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d4rken @ralfgehrer @jurajkusnier @chris-cwa