Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add check-Ins to submission payload (EXPOSUREAPP-5656) #2602

Merged
merged 19 commits into from
Mar 17, 2021
Merged

Add check-Ins to submission payload (EXPOSUREAPP-5656) #2602

merged 19 commits into from
Mar 17, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 12, 2021 •
edited

  • Provide Check-Ins to Submission payload
  • Create a transformer to transform Database check-ins to port-buff check-ins (Currently just mapping, it will do more than that )

Testing

  • Check if all fields are mapped according to Tech-Specs
  • Register a Test and submit your keys and check that is not affected by the change

@mtwalli mtwalli changed the title Add check-Ins to submission payload Add check-Ins to submission payload (EXPOSUREAPP-5656) Mar 12, 2021
@mtwalli mtwalli marked this pull request as ready for review March 12, 2021 19:16
@mtwalli mtwalli requested a review from a team March 12, 2021 19:16
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Mar 15, 2021
@harambasicluka harambasicluka added this to the 2.0.0 milestone Mar 15, 2021
@d4rken d4rken self-requested a review March 16, 2021 08:54
@d4rken d4rken self-assigned this Mar 16, 2021
d4rken
d4rken previously approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/EventRegistrationModule.kt Show resolved Hide resolved
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.4% 80.4% Coverage
0.0% 0.0% Duplication

LukasLechnerDev
LukasLechnerDev approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Scanned positive code and submitted my keys - everything continues to work fine.

@mtwalli mtwalli merged commit fc8ece0 into release/2.0.x Mar 17, 2021
@mtwalli mtwalli deleted the feature/5656-add-check-ins-submission-payload branch March 17, 2021 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

Assignees

@d4rken d4rken

@LukasLechnerDev LukasLechnerDev

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @d4rken @LukasLechnerDev @harambasicluka